Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

card section updated issue fixes #43

Merged
merged 4 commits into from
Oct 27, 2023
Merged

card section updated issue fixes #43

merged 4 commits into from
Oct 27, 2023

Conversation

umamenda
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 23, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 23, 2023

Page Scores Audits Google
/test/cards-new-221 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 23, 2023

Page Scores Audits Google
/test/cards-new-221 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 23, 2023

Page Scores Audits Google
/test/cards-new-221 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/test/cards-new-221 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

teshukatepalli1
teshukatepalli1 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@teshukatepalli1 teshukatepalli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teshukatepalli1 teshukatepalli1 merged commit b2340a8 into main Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teshukatepalli1 teshukatepalli1 teshukatepalli1 approved these changes

@pardeepgera23 pardeepgera23 Awaiting requested review from pardeepgera23

@dkuntze dkuntze Awaiting requested review from dkuntze

@davenichols-DHLS davenichols-DHLS Awaiting requested review from davenichols-DHLS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umamenda @teshukatepalli1