Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

footer development is completed with eslint issues #13

Merged
merged 8 commits into from
Oct 18, 2023
Merged

footer development is completed with eslint issues #13

merged 8 commits into from
Oct 18, 2023

Conversation

umamenda
Copy link
Collaborator

@umamenda umamenda commented Oct 13, 2023 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 13, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 13, 2023

Page Scores Audits Google
/footer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

dkuntze
dkuntze requested changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@dkuntze dkuntze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bottom part of the footer has visual difference between the actual site:

image

@umamenda
Copy link
Collaborator Author

umamenda commented Oct 14, 2023 •
edited
Loading

Hi @dkuntze,
Content issue fixed. footer black color will come from body css property. please review.

footer

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 16, 2023

Page Scores Audits Google
/footer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 16, 2023

Page Scores Audits Google
/footer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/footer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/footer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@umamenda
Copy link
Collaborator Author

umamenda commented Oct 17, 2023 •
edited
Loading

Hi @dkuntze,
All required changes are completed. Please review and merge.

  1. social icons anchor tags issue - fixed.
  2. foot logo anchor tag and link issue - fixed.
  3. background color for bottom footer issue - fixed.

Test URLs:

After: https://feature-footer--aldevron--hlxsites.hlx.page

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@umamenda umamenda requested a review from dkuntze October 17, 2023 15:53
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@pardeepgera23
Copy link
Collaborator

The bottom part of the footer has visual difference between the actual site:

image

@dkuntze - This has been fixed now

dkuntze
dkuntze approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@dkuntze dkuntze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. You can improve the LHS even more by adding labels to links, etc

@pardeepgera23 pardeepgera23 merged commit 0d1bda4 into main Oct 18, 2023
2 checks passed
@pardeepgera23 pardeepgera23 linked an issue Oct 19, 2023 that may be closed by this pull request
Create Footer Block #4
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkuntze dkuntze dkuntze approved these changes

@davenichols-DHLS davenichols-DHLS Awaiting requested review from davenichols-DHLS

@teshukatepalli1 teshukatepalli1 Awaiting requested review from teshukatepalli1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Footer Block
3 participants
@umamenda @pardeepgera23 @dkuntze