Fix enrichment bug #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hannessolo
reviewed
Mar 1, 2024
blocks/enrichment/enrichment.js
Outdated
| Array.from(sections[0].children) | ||
| .forEach((child) => wrapper.parentNode.insertBefore(child, wrapper)); | ||
| } else if (sections.length > 1) { | ||
| // If multiple section, append them to current section |
There was a problem hiding this comment.
append them to current section
You are inserting them after the current section, not to the current section, right?
There was a problem hiding this comment.
Yes the sections will be added after the section that contains the enrichment block. Let me update the comment to make this more clear.
hannessolo
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#textelements returned bysection.childNodes. So insteadsection.childrenis used.Test URLs: