Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart - latest alpha package #33

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Cart - latest alpha package #33

merged 2 commits into from
Feb 2, 2024

Conversation

fnhipster
Copy link
Collaborator

@fnhipster fnhipster commented Feb 2, 2024

Updating Cart – some minor fixes.

@herzog31 I had to fix styling on buttons because they were interfering with drop-ins buttons. Is there a better way to fix this and scope buttons from EDS to have a classname instead?

We are demoing this Friday Monday. It would be great if it can be merged to checkout-dropin

Test URLs

Copy link

aem-code-sync bot commented Feb 2, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 2, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fnhipster fnhipster merged commit 9fed4c9 into checkout-dropin Feb 2, 2024
2 checks passed
@fnhipster fnhipster deleted the update-cart branch February 2, 2024 15:03
dpatil-magento pushed a commit that referenced this pull request Oct 7, 2024
* dropins updates

* Update dropins.js

* override

* revert

* bump

* bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants