Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want headers for fetchGraphQl, and query params for catalog service, to be managed entirely in config rather than requiring developers to make code changes to github. To solve, we can introduce two mechanisms. First, config values are set with some consistent path, ie
commerce.headers.[scope].[header]
where scope is likepdp
andheader
is the string header key. The corresponding value will be injected as header or query param.This PR is an initial effort at using this syntax, currently only within the
config-dev
file, so usable in localhost/development on this PR only.TODO:
getQueryParams
function or is it OK to use both query param and headers (ie spread the result ofgetHeaders
over all header usage and query param usage for the scope?)Test URLs: