Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include last-modified in metadata #210

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Include last-modified in metadata #210

merged 2 commits into from
Nov 26, 2024

Conversation

herzog31
Copy link

  • Include new last-modified field in metadata sheet to return correct last-modified header for all products.
  • Minor fixes in open graph metatags.

Test URLs:

@herzog31 herzog31 added the changelog Important when updating projects label Nov 20, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 20, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 20, 2024 •
edited
Loading

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

rofe
rofe reviewed Nov 20, 2024
View reviewed changes
tools/pdp-metadata/pdp-metadata.js
@@ -144,6 +145,7 @@ const getProducts = async (config, pageNumber) => {
meta_description: finalDescription,
'og:image': baseImageUrl,
'og:image:secure_url': baseImageUrl,
'last-modified': lastModifiedAt,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this in ISO format?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rofe It is. You can double check the resulting file here: https://www.aemshop.net/products/default/metadata.json.

@herzog31 herzog31 merged commit 6cc6c93 into main Nov 26, 2024
2 checks passed
@herzog31 herzog31 deleted the last-modified branch November 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofe rofe rofe left review comments

@dicagno dicagno Awaiting requested review from dicagno

@hannessolo hannessolo Awaiting requested review from hannessolo

Assignees
No one assigned
Labels
changelog Important when updating projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herzog31 @rofe