Disable bfcache #196
Closed
Disable bfcache #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
sirugh
approved these changes
Nov 12, 2024
emipallares
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.corp.adobe.com/browse/USF-1710
There is an issue in the Event Bus. We "close" the BroadcastChannel during
pageunloadto enablebfcache. However, this also removes all listeners added to the channel, causing the drop-in UI not to update since the page is loaded from the cache, but the event listeners no longer exist. The short-term solution is to remove thepageunloadfrom the Event Bus to disablebfcache, and create a new ticket to support bfcache properly.Test URLs: