Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendations block with ACDL #11

Merged
merged 25 commits into from
Mar 15, 2024
Merged

Add recommendations block with ACDL #11

merged 25 commits into from
Mar 15, 2024

Conversation

herzog31
Copy link

@herzog31 herzog31 commented Nov 7, 2023

  • Added product recommendations which supports all available context (cart, category, product, page type, purchase and view history).
  • Added ACDL with basic commerce context and events.
  • Added ACDL schema validation. Create a sessionStorage entry acdl:debug = true to enable it.
  • When no recommendations are available, an empty placeholder is displayed to prevent layout shifts.
  • This PR is using a more lightweight version of ACDL based on Replace lodash adobe/adobe-client-data-layer#155.
  • Currently only the first returned recommendation unit is displayed.
  • TODO:
    • Add ACDL as npm dependency and use postinstall script like in 🛒 Commerce Dropins 🛒  #34.
    • Store visited products directly in session storage instead of relying on ACDL.
    • Populate eventInfo as required by event collector.
    • PLP / Search widget is not instrumented with storefront events, therefore PRecs will not work on these pages.
    • Search autocomplete widget to be instrumented with storefront events.
      • This uses an internal custom build. Check How To document.
    • Store purchase history from placeOrder events.
    • Add storefront events to product recommendations

Test URLs:

Copy link

aem-code-sync bot commented Nov 7, 2023

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/gear PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/gear PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 7, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/gear PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 9, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/gear PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 20, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/gear PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to recommendations January 8, 2024 11:14 Inactive
Copy link

aem-code-sync bot commented Jan 8, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cart PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/gear PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to recommendations January 8, 2024 11:35 Inactive
@herzog31 herzog31 marked this pull request as ready for review January 8, 2024 11:37
@herzog31 herzog31 requested a review from hannessolo January 8, 2024 11:38
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 5, 2024 14:47 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 5, 2024 16:06 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 6, 2024 13:40 Inactive
@herzog31 herzog31 changed the title Add recommendations block with ACDL2 Add recommendations block with ACDL Mar 6, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 6, 2024 14:26 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 7, 2024 13:27 Inactive
@herzog31 herzog31 requested a review from dicagno March 7, 2024 13:30
...product,
},
});
// TODO: Remove eventInfo once collector is updated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you already know what "updated" means, cool, but maybe you could add a specific version or ticket here.

@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 11, 2024 16:55 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 14, 2024 12:42 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to recommendations March 14, 2024 13:03 Inactive
@herzog31 herzog31 merged commit 6e764c1 into main Mar 15, 2024
2 checks passed
@herzog31 herzog31 deleted the recommendations branch March 15, 2024 10:42
@herzog31 herzog31 added changelog Important when updating projects and removed PREVIEW labels Jun 6, 2024
dpatil-magento pushed a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important when updating projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants