refactor code as in comments

hlxsites · Nov 20, 2024 · 1f78bbe · 1f78bbe
1 parent e74459a
commit 1f78bbe
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 25 deletions.
diff --git a/scripts/commerce.js b/scripts/commerce.js
@@ -153,14 +153,12 @@ query($sku: String!) {
 
 export async function commerceEndpointWithQueryParams() {
   // Set Query Parameters so they can be appended to the endpoint
-  const queryParameters = new URLSearchParams();
-  queryParameters.append('Magento-Environment-Id', await getConfigValue('commerce-environment-id'));
-  queryParameters.append('Magento-Website-Code', await getConfigValue('commerce-website-code'));
-  queryParameters.append('Magento-Store-View-Code', await getConfigValue('commerce-store-view-code'));
-  queryParameters.append('Magento-Store-Code', await getConfigValue('commerce-store-code'));
-  queryParameters.append('Magento-Customer-Group', await getConfigValue('commerce-customer-group'));
   const urlWithQueryParams = new URL(await getConfigValue('commerce-endpoint'));
-  urlWithQueryParams.search = queryParameters.toString();
+  urlWithQueryParams.searchParams.append('Magento-Environment-Id', await getConfigValue('commerce-environment-id'));
+  urlWithQueryParams.searchParams.append('Magento-Website-Code', await getConfigValue('commerce-website-code'));
+  urlWithQueryParams.searchParams.append('Magento-Store-View-Code', await getConfigValue('commerce-store-view-code'));
+  urlWithQueryParams.searchParams.append('Magento-Store-Code', await getConfigValue('commerce-store-code'));
+  urlWithQueryParams.searchParams.append('Magento-Customer-Group', await getConfigValue('commerce-customer-group'));
   return urlWithQueryParams;
 }
 

diff --git a/tools/picker/dist/index.515784d0.js → tools/picker/dist/index.56bd2c76.js b/tools/picker/dist/index.515784d0.js → tools/picker/dist/index.56bd2c76.js
diff --git a/tools/picker/dist/index.515784d0.js.map → tools/picker/dist/index.56bd2c76.js.map b/tools/picker/dist/index.515784d0.js.map → tools/picker/dist/index.56bd2c76.js.map
diff --git a/tools/picker/dist/index.96de328f.css b/tools/picker/dist/index.96de328f.css
diff --git a/tools/picker/dist/index.96de328f.css.map b/tools/picker/dist/index.96de328f.css.map
diff --git a/tools/picker/dist/index.html b/tools/picker/dist/index.html
@@ -1 +1 @@
-<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><title>Franklin Picker</title><link rel="stylesheet" href="index.96de328f.css"></head><body> <div id="app"></div> <script type="module" src="index.515784d0.js"></script> </body></html>
+<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><title>EDS Picker</title><link rel="stylesheet" href="index.96de328f.css"></head><body> <div id="app"></div> <script type="module" src="index.56bd2c76.js"></script> </body></html>
diff --git a/tools/picker/src/index.js b/tools/picker/src/index.js
@@ -122,16 +122,12 @@ async function performCatalogServiceQuery(query, config, variables) {
     };
 
     // Set Query Parameters so they can be appended to the endpoint
-    const queryParameters = new URLSearchParams();
-    queryParameters.append('Magento-Environment-Id', config['commerce-environment-id']);
-    queryParameters.append('Magento-Website-Code', config['commerce-website-code']);
-    queryParameters.append('Magento-Store-View-Code', config['commerce-store-view-code']);
-    queryParameters.append('Magento-Store-Code',config['commerce-store-code']);
-    queryParameters.append('Magento-Customer-Group', config['commerce-customer-group']);
-    const urlWithQueryParams = new URL(config['commerce-endpoint']);
-    urlWithQueryParams.search = queryParameters.toString()
-
-    const apiCall = urlWithQueryParams;
+    const apiCall = new URL(config['commerce-endpoint']);
+    apiCall.searchParams.append("Magento-Environment-Id", config['commerce-environment-id']);
+    apiCall.searchParams.append("Magento-Website-Code", config['commerce-website-code']);
+    apiCall.searchParams.append("Magento-Store-View-Code", config['commerce-store-view-code']);
+    apiCall.searchParams.append("Magento-Store-Code", config['commerce-store-code']);
+    apiCall.searchParams.append("Magento-Customer-Group", config['commerce-customer-group']);
     apiCall.searchParams.append('query', query.replace(/(?:\r\n|\r|\n|\t|[\s]{4})/g, ' ')
         .replace(/\s\s+/g, ' '));
     apiCall.searchParams.append('variables', variables ? JSON.stringify(variables) : null);
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><title>Franklin Picker</title><link rel="stylesheet" href="index.96de328f.css"></head><body> <div id="app"></div> <script type="module" src="index.515784d0.js"></script> </body></html>
		<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><title>EDS Picker</title><link rel="stylesheet" href="index.96de328f.css"></head><body> <div id="app"></div> <script type="module" src="index.56bd2c76.js"></script> </body></html>