Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asset Modal #51

Merged
merged 120 commits into from
Mar 15, 2024
Merged

Add Asset Modal #51

merged 120 commits into from
Mar 15, 2024

Conversation

mathieu-lessard
Copy link
Collaborator

JIRA: DXI-22446

Test URLs:

This differs from the previous PR as having additional changes to the ims account used. This is one which has been granted privileges and works with our marketinghub url.

synox and others added 30 commits November 22, 2023 17:08
… product profiles (#4)

* ASSETS-31822
Create separate security module for Unified Shell

* Setup delivery endpoint discovery
andrewmkhoury and others added 26 commits December 13, 2023 16:46
* DXI-23346: Hydration uses values from Algolia for selections

* Adjusted spacing

* Adjusted spacing

---------

Co-authored-by: Mathieu Lessard <[email protected]>
* Updated Asset Upload Experience

* Added comment regarding why the button change is delayed

---------

Co-authored-by: Mathieu Lessard <[email protected]>
- Added checkAddAssetsAccess() that will compare 'imsAuthorGroup' in 'admin-config.xlsx' in sharepoint to the IMS groups of the current user.
- Code that loads the 'Add Assets' button will now not execute unless checkAddAssetsAccess() returns true.
Copy link

aem-code-sync bot commented Mar 15, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Mar 15, 2024

Page Scores Audits Google
/qa/assets PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@cheintzman cheintzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathieu-lessard mathieu-lessard merged commit a519a51 into main Mar 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants