generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Asset Modal #51
Merged
Merged
Add Asset Modal #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… product profiles (#4) * ASSETS-31822 Create separate security module for Unified Shell * Setup delivery endpoint discovery
# Conflicts: # scripts/security.js
Co-authored-by: Mathieu Lessard <[email protected]>
* DXI-23346: Hydration uses values from Algolia for selections * Adjusted spacing * Adjusted spacing --------- Co-authored-by: Mathieu Lessard <[email protected]>
* Updated Asset Upload Experience * Added comment regarding why the button change is delayed --------- Co-authored-by: Mathieu Lessard <[email protected]>
- Added checkAddAssetsAccess() that will compare 'imsAuthorGroup' in 'admin-config.xlsx' in sharepoint to the IMS groups of the current user. - Code that loads the 'Add Assets' button will now not execute unless checkAddAssetsAccess() returns true.
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
cheintzman
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: DXI-22446
Test URLs:
This differs from the previous PR as having additional changes to the ims account used. This is one which has been granted privileges and works with our marketinghub url.