Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSETS-88889 : Add 'Share' button to the Collection Detail Page #42

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

TyroneAEM
Copy link
Collaborator

@TyroneAEM TyroneAEM commented Mar 8, 2024

No Jira Ticket has been created for this task
Here is the Workfront Ticket
https://experience.adobe.com/#/@wfadoberm/so:adoberm-Production/workfront/task/65e8e1b60025a9970141d7cd4303decc/updates

Test URLs: Before
https://main--adobe-gmo--hlxsites.hlx.page/collection/urn_cid_aem_0311ed8d-4e8d-46bd-83f6-af89f8e9d11a

Test URLs: After
https://assets-88889--adobe-gmo--hlxsites.hlx.page/collection/urn_cid_aem_0311ed8d-4e8d-46bd-83f6-af89f8e9d11a

Screenshot of the Collection page with the share button

image

Screenshot of the Toast message on the Collection page

Screenshot 2024-03-08 at 10 31 22 AM (3)

…lasses for right header, toast message, and share button

/blocks/adp-collection-header/adp-collection-header.js : Added JS and HTML for Share Button and Toast Message
@TyroneAEM TyroneAEM self-assigned this Mar 8, 2024
Copy link

aem-code-sync bot commented Mar 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Mar 8, 2024

Page Scores Audits Google
/collection/urn_cid_aem_0311ed8d-4e8d-46bd-83f6-af89f8e9d11a PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

.toast {
display: flex;
align-items: center;
background-color: #4CAF50; /* Dark green background */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TyroneAEM Please use #5258e4 code same to match current theme
image

Added default font family to toast
Copy link
Collaborator

@mathieu-lessard mathieu-lessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shiv-gup shiv-gup merged commit 2b09856 into main Mar 14, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants