ASSETS-34548 : Update the Collection API Endpoints #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1-347a-4c50-a55b-aad555671b22 which is a collection that was created with the new api to create a collection https://adobe-aem-assets-delivery-experimental.redoc.ly/#operation/createCollection Once the List All Collections API is working can this code be updated to be completed
…ollection(limit = undefined, page = 0) Pagination in files /adobe-gmo/blocks/adp-infinite-results-collections/CollectionsDatasource.js Needs to be fixed as not all the new Collections are showing up
…gination for the Collection Cards needs to be fixed
/scripts/collections.js : Tested that the getCollection method only works with the new Collections created with the Create and Update Collection API calls /adobe/assets/collections/{collectionId}/
…d in the header in the new Assets Delete API
…onsUrl()}/${collectionId} to ${getBaseAssetsCollectionsUrl()}/${collectionId}/items
…it = undefined, page = 0), added logic when the parameter page = null
to not add the page parameter in the data / body parameters
/blocks/adp-add-to-collection-modal/adp-add-to-collection-modal.js : Removed hard coded getCollection('urn:cid:aem:8f67c491-347a-4c50-a55b-aad555671b22') call to call the selected collection for add to an existing collection.
…host /scripts/collections.js : Removed deprecated listCollection function /blocks/adp-add-to-collection-modal/adp-add-to-collection-modal.js : Removed all the commented out old code that called listCollections /blocks/adp-add-to-collection-modal/adp-add-to-collection-modal.js : Removed all the commented out old code that called listCollections
…file admin-config.json
which is stored in a new property searchCollectionIndex e.g.
{
"ID": "searchCollectionIndex",
"Value": "108396-1046543_collections"
}
…them in the Collection dropdown list.
Deleted the dropdownSelect.addEventListener('scroll' .... as the <select> tag does not support the scroll event
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
mathieu-lessard
approved these changes
Feb 24, 2024
Authoring Edit the file admin-config.xlsx Then add the new property |
mohitar1
reviewed
Feb 29, 2024
mohitar1
reviewed
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA : ASSETS-34548
Test URLs:
Before: https://main--adobe-gmo--hlxsites.hlx.page/
After: https://assets-34548--adobe-gmo--hlxsites.hlx.page/qa/assets