Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets 33680 #26

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Assets 33680 #26

merged 4 commits into from
Jan 23, 2024

Conversation

cheintzman
Copy link
Collaborator

JIRA: ASSETS-33680

  • Changes were made to the CSS styling of links found in teasers as the previous colors did not conform to accessibility requirements
  • Changes were made to the CSS styling of links found on the landing page that are found withing paragraph elements (to avoid changing the "sign in" button) as the previous colors did not conform to accessibility requirements
  • Code was added to the landing page that allows for the detection of the video background color, and also allows for changing the landing page link colors dynamically based on the video background.
  • The video color detection only takes place for desktop, as for mobile users, links do not have a video background.

Test URLs:

Created getVideoColor() and waitForVideoLoad() in order to track the color of the background video and changed the CSS styling of Landing page links under a <p> element
Cleaned up some unused code and added a transition for the color change on landing page links
Copy link

aem-code-sync bot commented Jan 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 19, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cheintzman cheintzman merged commit b4d8028 into main Jan 23, 2024
0 of 2 checks passed
@cheintzman cheintzman deleted the ASSETS-33680 branch January 23, 2024 20:06
@cheintzman cheintzman restored the ASSETS-33680 branch January 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants