Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets 32396 #22

Closed
wants to merge 2 commits into from
Closed

Assets 32396 #22

wants to merge 2 commits into from

Conversation

cheintzman
Copy link
Collaborator

@cheintzman cheintzman commented Dec 8, 2023

JIRA: ASSETS-32396

Made changes to getQuickLinkConfig() in site-config.js in order to place the FAQ link (if found) in the Quick Links section of the header to the last position. Tested locally, but as per below, Test URLs do not yet function on pages that require authentication.

image

Test URLs:

@cheintzman cheintzman requested a review from shiv-gup December 8, 2023 17:43
Copy link

aem-code-sync bot commented Dec 8, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 8, 2023

Page Scores Audits Google
/sample-public-site Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@shiv-gup
Copy link
Collaborator

shiv-gup commented Dec 8, 2023

JIRA: ASSETS-32396

Made changes to getQuickLinkConfig() in site-config.js in order to place the FAQ link (if found) in the Quick Links section of the header to the last position. Tested locally, but as per below, Test URLs do not yet function on pages that require authentication.

Test URLs:

@cheintzman Can you please add screenshot from your local, how the change looks?
Moving FAQ to the last position of the header, code changes are not required. You can update the site-config.xlsx file and make sure to add FAQ last in the list.
Test Link: https://main--adobe-gmo--hlxsites.hlx.live/drafts/Shivani/assets
cc: @nithinasokan @sammitpotade

@cheintzman
Copy link
Collaborator Author

Screenshot has now been added to the PR description

@cheintzman cheintzman closed this Dec 8, 2023
@cheintzman cheintzman deleted the ASSETS-32396 branch December 8, 2023 19:11
@cheintzman cheintzman restored the ASSETS-32396 branch December 11, 2023 14:28
@cheintzman cheintzman deleted the ASSETS-32396 branch December 11, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants