Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXI- 29263 #180

Merged
merged 12 commits into from
Nov 19, 2024
Merged

DXI- 29263 #180

merged 12 commits into from
Nov 19, 2024

Conversation

staware30
Copy link
Collaborator

  • Fixed a null pointer exception.
image
  • I found a bug where, if the scope ID had the same value, the associated button was not rendering so have fixed as well.

Test url:
https://dxi-29263--adobe-gmo--hlxsites.hlx.page/program-details?programName=Illustrator%20June%20Release&programID=662fed0d0289b3f642e78577cffc0dd4&path=/content/dam/gmo-cf/en/digital-media-dme/programs/illustrator-june-release-662fed0d0289b3f642e78577cffc0dd4

Also, I will remove all the console logs once I test everything in QA (hope that is fine)

Copy link

aem-code-sync bot commented Nov 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@staware30 staware30 merged commit bcc4c22 into rc Nov 19, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants