Marketing Dashboard and Program Detail Optimization by adding the Content Fragment Path #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getAllCampaigns for Program List executeQuery for Program Details
…page, which now is passed to the graphql query getProgramDetails which now has the path parameter query ($programName: String, $programID:String, $path:ID)
…query string - Corrected the `extractQueryVars` function to properly handle and return the correct value for `programName`, ensuring that the `+` character is not mistakenly replaced with a space. - Updated the construction of `programQueryString` to include the `path` parameter only if `encodedPath` is not an empty string. - These changes improve the accuracy of parameter handling and optimize the query string construction process.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
shiv-gup
reviewed
Aug 26, 2024
shiv-gup
reviewed
Aug 26, 2024
…e performance - Replaced array-based caching with an object-based caching system using a combination of `programName`, `campaignName`, and `deliverableType` as the cache key. - Updated the `addThumbnailToItem` function to utilize the new caching mechanism, reducing redundant API calls. - Converted the outer loop from `forEach` to `for...of` to ensure proper handling of asynchronous operations and to support the sequential execution of `await` calls.
TyroneAEM
force-pushed
the
assets-72031
branch
from
ab5eb5b to
95bec45
Compare
Fixed Merge Conflicts # Conflicts: # blocks/gmo-program-details/gmo-program-details.js # scripts/program-calendar.js Added Thumbnail caching to blocks/gmo-program-details/gmo-program-details.js Deleted file scripts/program-calendar.js
shiv-gup
reviewed
Aug 28, 2024
- Modified the cache key generation logic to only include campaignName if it is not null or an empty string.
shiv-gup
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://experience.adobe.com/#/@wfadoberm/so:adoberm-Production/workfront/task/66c36080001a1f4993ee64439ad4629a/overview
JIRA: ASSETS-00000
Test URLs:
Marketing Dashboard
https://assets-72031--adobe-gmo--hlxsites.hlx.page/qa/marketing-dashboard
Program Detail
https://assets-72031--adobe-gmo--hlxsites.hlx.page/qa/program-details?programName=Acrobat%27s%20Got%20It&programID=6578983c049d6162a756ac83e90f3ccb&path=/content/dam/gmo-cf/en/digital-media-dme/programs/fy24-agi3-0-de-campaign-666017ba00b03fe37af940a93c5a04e2