Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSETS-88925 : Review and Improve Page Performance of Marketing Moment Landing page #133

Closed
wants to merge 1 commit into from

Conversation

TyroneAEM
Copy link
Collaborator

Improved changes

  • Implement debounce for search input to reduce the number of API calls.
  • Refactor the decorate function for better readability and performance.
  • Add lazy loading for images using IntersectionObserver to load images only when they come into view.
  • Move pagination button toggling to a separate togglePaginationButtons function.

https://experience.adobe.com/#/@wfadoberm/so:adoberm-Production/workfront/task/668c190a002545eb036d1a66018bd8db/overview

Test URLs:

- Implement debounce for search input to reduce the number of API calls.
- Refactor the `decorate` function for better readability and performance.
- Add lazy loading for images using `IntersectionObserver` to load images only when they come into view.
- Move pagination button toggling to a separate `togglePaginationButtons` function.
- Ensure strict comparison (`===`) for block configuration check.
@TyroneAEM TyroneAEM self-assigned this Jul 9, 2024
Copy link

aem-code-sync bot commented Jul 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 9, 2024

Page Scores Audits Google
/marketing-dashboard PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TyroneAEM TyroneAEM closed this Jul 9, 2024
@TyroneAEM
Copy link
Collaborator Author

Making more changes..
Will reopen when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant