Skip to content

Commit

Permalink
Pull Request Review Changes
Browse files Browse the repository at this point in the history
/blocks/adp-collection-header/adp-collection-header.css : Removed Todo comment
/blocks/adp-collection-header/adp-collection-header.js :  Changed back to  await deleteCollection(collectionId, collection.title);
/blocks/adp-share-header/adp-share-header.css: Removed redundant CSS classes
  • Loading branch information
TyroneAEM committed Mar 1, 2024
1 parent 765c4b4 commit eb0253a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
1 change: 0 additions & 1 deletion blocks/adp-collection-header/adp-collection-header.css
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
vertical-align: text-bottom;
}

/*Todo New CSS */
.adp-collection-header-collection-info {
display: flex;
flex-direction: column; /* Stack the title and sub-info vertically */
Expand Down
2 changes: 1 addition & 1 deletion blocks/adp-collection-header/adp-collection-header.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function createCollectionInfoHeader(collectionInfoHeader, collection) {
'Delete collection',
`Are you sure you want to delete the collection "${collection.title}"?`,
async () => {
await deleteCollection(collectionId, collection.title, collection.etag);
await deleteCollection(collectionId, collection.title);
navigateTo(createLinkHref('/collections'));
},
'Proceed',
Expand Down
14 changes: 1 addition & 13 deletions blocks/adp-share-header/adp-share-header.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
.section.adp-share-header-left-container {
padding-right: 0;
}

.adp-share-header {
display: flex;
Expand All @@ -26,15 +23,6 @@
align-items: center; /* Centers items vertically */
}

.adp-share-stats {
border: #E6E6E6 1px solid;
border-radius: 6px;
font: 11px/14px var(--body-font-family);
padding: 6px 10px;
flex-shrink: 0;
margin-right: 20px; /* Adjust the 20px to whatever fixed space you want between the items and the checkbox */
}

.adp-share-select-all {
display: flex;
align-items: center; /* This will vertically align the checkbox and label */
Expand All @@ -49,7 +37,7 @@
flex-direction: column; /* Stack the title and sub-info vertically */
}

.adp-share-header .adp-share-title {
.adp-share-header {
font: var(--collection-heading-font);
width: 100%;
}
Expand Down

0 comments on commit eb0253a

Please sign in to comment.