Corrected validation now that select fields are comboboxes

hlxsites · Apr 16, 2024 · e739a63 · e739a63
1 parent 2cb00f2
commit e739a63
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/contenthub/hydration/hydration-utils.js b/contenthub/hydration/hydration-utils.js
@@ -24,7 +24,7 @@ export function formIsComplete(metadataSchema, formValues) {
   const incomplete = metadataSchema.find((schema) => {
     if(!schema.required) return;
     if(schema.requires) return;
-    return Array.isArray(formValues[schema.mapToProperty]) ? formValues[schema.mapToProperty].length === 0 : formValues[schema.mapToProperty] === '';
+    return !(schema.mapToProperty in formValues) || Array.isArray(formValues[schema.mapToProperty]) ? formValues[schema.mapToProperty].length === 0 : formValues[schema.mapToProperty] === '';
   });
 
   if(incomplete) return false;
@@ -197,15 +197,12 @@ export function getMetadataSchema(facetOptions){
           placeholder: 'Select one',
           element: 'text',
           getSuggestions: async (value) => {
-            return  [
-              {id: '', name: 'N/A'}, 
-              ...facetOptions['gmo-campaignName'].filter(
-                (option) => {
-                  const name = option.name.toLowerCase();
-                  return value.toLowerCase().split(' ').every((val) => name.includes(val));
-                }
-              )
-            ]
+            return facetOptions['gmo-campaignName'].filter(
+              (option) => {
+                const name = option.name.toLowerCase();
+                return value.toLowerCase().split(' ').every((val) => name.includes(val));
+              }
+            )
           },
         },
         {