Skip to content

Commit

Permalink
Assets 98994 (#81)
Browse files Browse the repository at this point in the history
* many updates

* finish dynamic properties

- all properties should be dynamic based on graphql data
- refactored some common lookups to a shared javascript file
- updated overflow for overview/description
- made status, products more presentable
- more elegant handling of empty audience and kpi lists

* test rename svg to resolve issue

* finish updating icon names and mapping

* initial changeover from static to dynamic data

* adjustments based on feedback

* additional changes based on feedback

* minor bugfix, null checks

* squash final bug with read more

* final touches

* combine two graphql functions with duplicated code

* bugfixes per pr review
  • Loading branch information
mdickson-adbe authored May 10, 2024
1 parent 5e14728 commit 7a4caa1
Show file tree
Hide file tree
Showing 3 changed files with 101 additions and 460 deletions.
17 changes: 15 additions & 2 deletions blocks/gmo-campaign-details/gmo-campaign-details.css
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ body {
margin-top: 20px;
margin-bottom: 20px;
}
& .description {
& .product-overview-wrapper {
margin-bottom: 20px;
}
& .description, .overview {
margin-top: 10px;
font: normal normal normal 14px/21px Adobe Clean;
letter-spacing: 0px;
Expand Down Expand Up @@ -278,6 +281,7 @@ body {
margin-left: -20px;
margin-right: -20px;
padding-left: 20px;
padding-right: 20px;
height: 64px;
color: #505050;
display: flex;
Expand All @@ -295,6 +299,7 @@ body {
}
&.datarow {
display: flex;
align-items: center;
height: 88px;
font-weight: 200;
& .property {
Expand All @@ -303,6 +308,11 @@ body {
&:first-child, &:nth-child(2) {
border-top: 2px solid #F4F4F4;
}
& .deliverable-name, .platforms {
overflow: hidden;
text-overflow: ellipsis;
line-height: 16px;
}
}
&.collapsible.header {
height: unset;
Expand Down Expand Up @@ -383,9 +393,12 @@ body {
margin-left: 45px;
}
.column1 {
width: 200px;
}
.column3 {
width: 140px;
}
.column3, & .column4, & .column5, & .column6 {
.column4, & .column5, & .column6 {
width: 110px;
}
.column2 {
Expand Down
Loading

0 comments on commit 7a4caa1

Please sign in to comment.