This repository has been archived by the owner on Jul 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
Phpcs cleanup #94
Open
carl-alberto
wants to merge
20
commits into
hlashbrooke:master
Choose a base branch
from
carl-alberto:phpcs-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Phpcs cleanup #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-admin Feature/fix private admin
Adds class name option to build & Adds build task to Gruntfile
Update uninstall.php
This fixes the redundant post type name after a new entry
update init localization according to WP >= 4.6 documentation
Include possibility to customize options prefix
Any news here? |
@carl-alberto looks good. You now have the relevant rights to merge now, so I'll leave it in your capable hands :-) |
Thank @jonathanbossenger, let me try to review this weekend regarding the #89 issue as well as the complete phpcs cleanup from the other Pr's |
@carl-alberto @jonathanbossenger thanks for your work to update this plugin. Got a tip jar? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should mostly address these issues to comply with WPPHPCS:
#91
#81