Support for annotations #247
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPTK
reviewed
Dec 4, 2024
| if blk.isEmpty then | ||
| err((msg"Expected ${subRule.whatComesAfter} ${subRule.mkAfterStr}; found end of block instead" -> S(loc) :: Nil)) | ||
| errExpr | ||
| blk ::: blockContOf(rule) | ||
| blk ::: blockContOf(rule) // TODO: apply headAnnotations |
There was a problem hiding this comment.
Not a fan of this. We're going to be silently dropping some information, which is always the worst to debug, if/when we eventually look into why this case is not working.
Do you have a test case that reproduces this path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to support annotations. As we discussed, recursive pattern normalization/compilation should be an opt-in feature and can be enabled by an annotation. For example,
I have only completed parsing as the first step. I am still not sure how it should be handled in the
Elaborator, so I put this PR in draft status.