-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tuple patterns #232
Conversation
9f0ccc9
to
eaf60b3
Compare
00faff0
to
251d1c1
Compare
18f5125
to
3c32ef4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks! I only have two main change requests.
First, please add a test that pattern-matches tuples within a function fun foo(tupleGet) = ...
. Realize your foolishness. Then fix the bug.
Second, please comment out the vast majority of the uses of the :ucs
flag. This produces extremely verbose debugging output that's mostly noise and creates so many diff changes. Especially since it prints symbol UIDs (it probably shouldn't). At most, please only keep a few small but representative uses of :ucs
, which can be used to check if there is a regression in the UCS logic. Currently there is just so much output noise that any change creates tons of diffs and regressions may as well go unnoticed, which completely defeats the purpose of diff-testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome contribution, thanks!
No description provided.