Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elaboration of case and support as patterns #231

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

chengluyu
Copy link
Member

Can we non-squash merge this PR?

@chengluyu chengluyu changed the title No need to turn off type checking globally Fix elaboration of case and support as patterns Nov 6, 2024
@LPTK
Copy link
Contributor

LPTK commented Nov 6, 2024

Can we non-squash merge this PR?

Of course. I squash-merge PRs when some of the commits messages are like "update test output" and "fix". If the commits are clean, I prefer keeping them.

@LPTK
Copy link
Contributor

LPTK commented Nov 7, 2024

As discussed, we'll just squash-merge this one.

@LPTK LPTK merged commit b379b98 into hkust-taco:hkmc2 Nov 7, 2024
1 check passed
@LPTK LPTK deleted the hkmc2-ucs2 branch November 7, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants