Feature/27616 mappings extraction #653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit tests are broken
unit tests are compiling but broken because of the missing migration
we can load the legacy config and transform it to the new information missing: We need to be able to write it somehow.
adaper migration almost works
it just compiles(maybe works)
… adapter specific configuration
codepitbull
reviewed
Nov 22, 2024
| @@ -309,7 +314,19 @@ public int getDepth() { | |||
| final Map<String, Object> config = objectMapper.convertValue(adapter.getConfig(), new TypeReference<>() { | |||
| }); | |||
|
|
|||
| protocolAdapterManager.updateAdapterConfig(adapterId, config); | |||
|
|
|||
| // TODO we need to extract the mappings from the adapter object | |||
There was a problem hiding this comment.
What are we doing with these TODOs?
Another PR?
codepitbull
reviewed
Nov 22, 2024
| return ErrorResponseUtil.errorResponse(HttpStatus.NOT_FOUND_404,"Adapter not found", "The adapter named '" + | ||
| domainTag.getProtocolId() + | ||
| "' does not exist."); | ||
| return ErrorResponseUtil.errorResponse(HttpStatus.NOT_FOUND_404, |
codepitbull
reviewed
Nov 22, 2024
| .entity(new TagSchema(protocolId, | ||
| customConfigSchemaGenerator.generateJsonSchema(info.tagConfigurationClass()))) | ||
| .build()) | ||
| .orElseGet(() -> ErrorResponseUtil.errorResponse(404, |
codepitbull
reviewed
Nov 22, 2024
| import java.util.Map; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| @SuppressWarnings({"FieldMayBeFinal", "unused"}) |
There was a problem hiding this comment.
I guess we donÄt use final here because of JAXB deserialization?
Might be worth a comment.
codepitbull
reviewed
Nov 22, 2024
|
|
||
| public void migrate() { | ||
| try { | ||
| // TODO check whether the migration is needed |
There was a problem hiding this comment.
I guess that's what you are working on right now?
codepitbull
reviewed
Nov 22, 2024
| if (protocolAdapterFactory == null) { | ||
| // not much we can do here. We do not have the factory to get the necessary information from | ||
| //TODO log | ||
| log.error("Fucked"); |
There was a problem hiding this comment.
Yeh ... that needs to go (I know I put it there ;) )
codepitbull
reviewed
Nov 22, 2024
| System.exit(1); | ||
| } | ||
| log.error("Could not read the configuration file {}. Exiting HiveMQ Edge.", configFile.getAbsolutePath()); | ||
| log.debug("Original error message:", e); |
There was a problem hiding this comment.
Let's add this to the. error log.
This information will be vital in case we really run int osomething like that.
codepitbull
reviewed
Nov 22, 2024
| import java.util.Map; | ||
|
|
||
| public class ProtocolAdapterConfigurationServiceImpl implements ProtocolAdapterConfigurationService { | ||
|
|
||
| private @NotNull Map<String, Object> allConfigs = Map.of(); | ||
| private @NotNull List<ProtocolAdapterEntity> allConfigs = new ArrayList<>(); |
There was a problem hiding this comment.
Does this need to be thread-safe?
codepitbull
reviewed
Nov 22, 2024
| private final int maxQoS; | ||
|
|
||
| public FromEdgeMapping( | ||
| @NotNull final String tagName, |
There was a problem hiding this comment.
NotNull / final ordering
codepitbull
reviewed
Nov 22, 2024
| } | ||
|
|
||
| public @NotNull List<Map<String, Object>> tagsToMaps(final @NotNull List<? extends Tag> tags) { | ||
| return tags.stream().map(tag -> mapper.convertValue(tag, new TypeReference<Map<String, Object>>() { |
There was a problem hiding this comment.
Having map and collect each on a new line makes reading easier.
codepitbull
reviewed
Nov 22, 2024
| private final @NotNull String tagName; | ||
| private final @NotNull String topicFilter; | ||
| private final int mqttMaxQoS; | ||
| private final @com.hivemq.extension.sdk.api.annotations.NotNull FieldMappings fieldMappings; |
codepitbull
reviewed
Nov 22, 2024
exclude simulation from tag verification
…/hivemq-edge into feature/27616-mappings-extraction
…/hivemq-edge into feature/27616-mappings-extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/57/cards/28013/details/