Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tenure height #1885

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat: added tenure height #1885

merged 1 commit into from
Oct 31, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Oct 30, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adding tenure height to block page.
Our @stacks/blockchain-api-client is outdated.

  api.blocksApi.getBlockByHash({
      hash,
    }),

does not have the correct, up-to-date types, so it's not returning tenure height.
Therefore, I am using fetch for now until we update @stacks/blockchain-api-client and get the new types as well.
I am waiting to do this, as there were some breaking changes and so I think this will be a big task that we should discuss @He1DAr
I also removed the microblocks page as from my understanding that page is no longer used

Issue ticket number and link

#1624 (comment)

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

@BLuEScioN BLuEScioN requested a review from He1DAr October 30, 2024 18:45
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 5:24pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 5:24pm

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/common/queries/useBlockByHash.ts 0.00% 7 Missing and 1 partial ⚠️
src/app/block/[hash]/PageClient.tsx 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

src/app/block/[hash]/PageClient.tsx Outdated Show resolved Hide resolved
@blockstack-devops
Copy link

🎉 This PR is included in version 1.222.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants