Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add my appreciation #345

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Add my appreciation #345

wants to merge 1 commit into from

Conversation

rzpqyo
Copy link

@rzpqyo rzpqyo commented Jun 1, 2014

記事に従い、初めてpull requestしてみました。
宜しくお願い致します。

raimon49
raimon49 requested changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@raimon49 raimon49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzpqyo Pull Requestありがとうございます。

変更差分を確認したところ、ファイル全体の改行コードが、元ファイルはWindows改行コードだったものからUnix改行コードに変わってしまっているようです。

利用されているテキストエディタ環境などが分からずうまく伝えることが難しいのですが、改行コードをWindows改行コードのままで感想を追加してもらえないでしょうか？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimon49 raimon49 raimon49 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzpqyo @raimon49