fix: apply suggestions from code review

hirale · Nov 23, 2024 · 6668603 · 6668603
1 parent cada379
commit 6668603
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/app/code/core/Mage/Api2/Model/Auth/Adapter/Oauth2.php b/app/code/core/Mage/Api2/Model/Auth/Adapter/Oauth2.php
@@ -26,11 +26,13 @@ class Mage_Api2_Model_Auth_Adapter_Oauth2 extends Mage_Api2_Model_Auth_Adapter_A
     /**
      * Process request and figure out an API user type and its identifier
      *
-     * Returns Varien_Object with two properties: type and id
+     * Returns stdClass object with two properties: type and id
+     *
+     * @return stdClass
      */
-    public function getUserParams(Mage_Api2_Model_Request $request): Varien_Object
+    public function getUserParams(Mage_Api2_Model_Request $request)
     {
-        $userParamsObj = new Varien_Object(['type' => null, 'id' => null]);
+        $userParamsObj = (object) ['type' => null, 'id' => null];
 
         try {
             $token = $this->_validateToken($request);

diff --git a/app/code/core/Mage/Oauth2/Block/Adminhtml/Client/Edit.php b/app/code/core/Mage/Oauth2/Block/Adminhtml/Client/Edit.php
@@ -14,7 +14,7 @@
  * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
- declare(strict_types=1);
+declare(strict_types=1);
 
 class Mage_Oauth2_Block_Adminhtml_Client_Edit extends Mage_Adminhtml_Block_Widget_Form_Container
 {

diff --git a/app/code/core/Mage/Oauth2/Block/Adminhtml/Client/Edit/Form.php b/app/code/core/Mage/Oauth2/Block/Adminhtml/Client/Edit/Form.php
@@ -14,7 +14,7 @@
  * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
- declare(strict_types=1);
+declare(strict_types=1);
 
 class Mage_Oauth2_Block_Adminhtml_Client_Edit_Form extends Mage_Adminhtml_Block_Widget_Form
 {