Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting the tests from Enzyme to Testing Library. #54

Closed
tigerabrodi opened this issue May 17, 2021 · 6 comments · Fixed by #57
Closed

Converting the tests from Enzyme to Testing Library. #54

tigerabrodi opened this issue May 17, 2021 · 6 comments · Fixed by #57

Comments

@tigerabrodi
Copy link

Hi 👋

I recognized your library when looking for a solution that allows me to check the previous pathname. 😁

I saw that you guys are currently using Enzyme, which itself seems to be blocking the support of React 17+.

I and many friends are a part of the Open Source Raid Guild, a group that supports OSS projects. 💙

Many of us work together on one large PR. 🤓

We would fork your project to our Github Team and work on our fork, and communicate with some of the maintainers closely over at Discord.

Read more about us: https://github.com/OpenSourceRaidGuild/tutorial-quest#hi-wave-welcome-to-the-open-source-raid-guild-crossed_swords

Our discord server: https://discord.gg/JczjG8su

Let us know if you've any questions, and feel free to join the Discord already, even if it is just a question. 🥳
@joealden
Copy link
Contributor

@hinok FYI this would unblock #46.

@hinok
Copy link
Owner

hinok commented Jun 3, 2021 •
edited
Loading

@joealden @tigerabrodi Feel free to create a PR here that will use react-testing-library instead of enzyme. I'm happy to merge it once it will be done and publish a new version.

@JacobMGEvans
Copy link
Contributor

We will create a PR soon.

Any objections to adding more tests as well?

@hinok
Copy link
Owner

hinok commented Jun 8, 2021

@JacobMGEvans The current code coverage is 99% so if you want to reach 100%, go ahead 😱 🥳

@JacobMGEvans JacobMGEvans mentioned this issue Jun 8, 2021
Merged
@JacobMGEvans
Copy link
Contributor

@hinok Nearly done.

@JacobMGEvans
Copy link
Contributor

Should have something by this weekend.

@hinok hinok closed this as completed in #57 Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

React Testing Library Conversion OpenSourceRaidGuild/react-router-last-location
4 participants
@hinok @joealden @JacobMGEvans @tigerabrodi