Skip to content

Commit

Permalink
feat: Add extended explain info to Comet plan (apache#255)
Browse files Browse the repository at this point in the history
* feat: Add extended explain info to Comet plan

Requires Spark 4.0.0 for the explain info to be visible in Spark UI.
(see: https://issues.apache.org/jira/browse/SPARK-47289)

* spotless apply

* Address review comments

* fix ci

* Add one more explanation

* address review comments

* fix formatting after rebase
  • Loading branch information
parthchandra authored and Steve Vaughan Jr committed Apr 23, 2024
1 parent 370d641 commit b457d3b
Show file tree
Hide file tree
Showing 13 changed files with 1,860 additions and 162 deletions.
2 changes: 2 additions & 0 deletions dev/ensure-jars-have-correct-contents.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ allowed_expr+="|^org/apache/spark/shuffle/sort/CometShuffleExternalSorter.*$"
allowed_expr+="|^org/apache/spark/shuffle/sort/RowPartition.class$"
allowed_expr+="|^org/apache/spark/shuffle/comet/.*$"
allowed_expr+="|^org/apache/spark/sql/$"
# allow ExplainPlanGenerator trait since it may not be available in older Spark versions
allowed_expr+="|^org/apache/spark/sql/ExtendedExplainGenerator.*$"
allowed_expr+="|^org/apache/spark/CometPlugin.class$"
allowed_expr+="|^org/apache/spark/CometDriverPlugin.*$"
allowed_expr+="|^org/apache/spark/CometTaskMemoryManager.class$"
Expand Down
3 changes: 3 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,9 @@ under the License.
<ignoreClass>javax.annotation.meta.TypeQualifierValidator</ignoreClass>
<!-- this class is not properly excluded from comet-spark right now -->
<ignoreClass>org.apache.parquet.filter2.predicate.SparkFilterApi</ignoreClass>
<!-- we explicitly include a duplicate to allow older versions of Spark -->
<!-- this can be removed once we no longer support spark 3.x -->
<ignoreClass>org.apache.spark.sql.ExtendedExplainGenerator</ignoreClass>
</ignoreClasses>
</dependency>
<dependency>
Expand Down
Loading

0 comments on commit b457d3b

Please sign in to comment.