A VecCheckNan issue (#491)

* Update test_vec_check_nan.py add test for numpy ndarray * Update vec_check_nan.py * Update test_vec_check_nan.py add some space * Update changelog.rst * Update changelog.rst * Update test_vec_check_nan.py * Update docs/misc/changelog.rst Co-Authored-By: Antonin RAFFIN <[email protected]> * Update changelog.rst * Update test_vec_check_nan.py
hill-a · Sep 28, 2019 · f6ab57c · f6ab57c
1 parent 46d13b4
commit f6ab57c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst
@@ -42,6 +42,7 @@ Bug Fixes:
   `Issue #430 <https://github.com/hill-a/stable-baselines/issues/430>`_.
 - Fix a bug when calling `logger.configure()` with MPI enabled (@keshaviyengar)
 - set `allow_pickle=True` for numpy>=1.17.0 when loading expert dataset
+- Fix a bug when using VecCheckNan with numpy ndarray as state.  `Issue #489 <https://github.com/hill-a/stable-baselines/issues/489>`_.
 
 Deprecations:
 ^^^^^^^^^^^^^
@@ -481,4 +482,4 @@ In random order...
 Thanks to @bjmuld @iambenzo @iandanforth @r7vme @brendenpetersen @huvar @abhiskk @JohannesAck
 @EliasHasle @mrakgr @Bleyddyn @antoine-galataud @junhyeokahn @AdamGleave @keshaviyengar @tperol
 @XMaster96 @kantneel @Pastafarianist @GerardMaggiolino @PatrickWalter214 @yutingsz @sc420 @Aaahh @billtubbs
-@Miffyli @dwiel @miguelrass @qxcv @jaberkow @eavelardev
+@Miffyli @dwiel @miguelrass @qxcv @jaberkow @eavelardev @ruifeng96150
diff --git a/stable_baselines/common/vec_env/vec_check_nan.py b/stable_baselines/common/vec_env/vec_check_nan.py
@@ -55,8 +55,8 @@ def _check_val(self, *, async_step, **kwargs):
 
         found = []
         for name, val in kwargs.items():
-            has_nan = any(np.isnan(val))
-            has_inf = self.check_inf and any(np.isinf(val))
+            has_nan = np.any(np.isnan(val))
+            has_inf = self.check_inf and np.any(np.isinf(val))
             if has_inf:
                 found.append((name, "inf"))
             if has_nan:

diff --git a/tests/test_vec_check_nan.py b/tests/test_vec_check_nan.py
@@ -16,9 +16,9 @@ def __init__(self):
 
     @staticmethod
     def step(action):
-        if all(np.array(action) > 0):
+        if np.all(np.array(action) > 0):
             obs = float('NaN')
-        elif all(np.array(action) < 0):
+        elif np.all(np.array(action) < 0):
             obs = float('inf')
         else:
             obs = 0
@@ -68,3 +68,5 @@ def test_check_nan():
     else:
         assert False
 
+
+    env.step(np.array([[0, 1], [0, 1]]))