Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing location information on concatenation #9

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

dontcallmedom
Copy link
Contributor

No description provided.

@hildjj
Copy link
Owner

hildjj commented Apr 18, 2024

Did you check the rest of file for other places this might be needed?
Is it possible to add a test that catches this?

Please add yourself to a new contributors section of the package.json file.

@dontcallmedom
Copy link
Contributor Author

I spotted another missing location call (added in 6ee0b24) and added myself to contributors in 708512b.

I had considered adding a test, but since there was no existing infrastructure around testing for location, and since I'm not familiar with ava, this felt more than I could contribute at this time :)

@hildjj
Copy link
Owner

hildjj commented Apr 19, 2024

No worries on the test, and thanks for the contribution!

@hildjj hildjj merged commit 1c3cf8b into hildjj:main Apr 19, 2024
3 checks passed
hildjj added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants