Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add PHP 8.2 & 8.3 to CI #29

Merged
merged 2 commits into from
Mar 13, 2024
Merged

test: add PHP 8.2 & 8.3 to CI #29

merged 2 commits into from
Mar 13, 2024

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Mar 8, 2024

Description

Add test with PHP 8.2 & 8.3 in GitHub Actions

Motivation and context

I want to use the library into a project and I want to ensure every things is OK with latest PHP version.

How has this been tested?

It only impact the CI.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@hidehalo
Copy link
Owner

I create a new issue for this requirement.

@hidehalo hidehalo mentioned this pull request Mar 11, 2024
@jdecool
Copy link
Contributor Author

jdecool commented Mar 11, 2024

Just push a fix for those errors.

@hidehalo
Copy link
Owner

Just push a fix for those errors.

@jdecool Thx for your help!

CI tests still failed

It seems PHPUnit configuration file need migrate on PHP 8.1 & 8.2 & 8.3.

We can migrate the stale configuration file first by following PHPUnit's instructions and then observe its backward compatibility & CI test results.

Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"

@jdecool
Copy link
Contributor Author

jdecool commented Mar 12, 2024

Just push an updated version of the PHPUnit configuration.

@hidehalo
Copy link
Owner

@jdecool Great job! Every things is OK now.

@hidehalo hidehalo merged commit 1233099 into hidehalo:master Mar 13, 2024
20 checks passed
@jdecool jdecool deleted the gha-active-versions branch March 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants