Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow signup, adding fullname to signup payload #94

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

gregfrasco
Copy link
Member

@gregfrasco gregfrasco commented Feb 6, 2024

Description

  • Blocked Signup if allow signup is false
  • Passed down fullname in signup payload to user service
  • Replaced auth tests so they are functional. At ~75% test coverage

Checklist

  • This PR can be reviewed in under 30 minutes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have assigned reviewers to this PR.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 886ad701
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (886ad70) Report Missing Report Missing Report Missing
Head commit (8d3597d) 874 403 46.11%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#94) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@vpsx vpsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the branch and repeated the signup sequence I did previously - can now see the full name(s) when listing users after signup, & now see an error after changing allowSignup to false and trying to sign up again 🎉 I dunno about the tests but otherwise lgtm

@gregfrasco gregfrasco merged commit 31f68c1 into main Feb 15, 2024
5 checks passed
@gregfrasco gregfrasco deleted the fix/allow-signup branch February 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants