Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gif #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make gif #69

wants to merge 2 commits into from

Conversation

ziad-abdo
Copy link
Collaborator

@ziad-abdo ziad-abdo commented Dec 24, 2020

This is just the start. But this piece took me way longer than I'd like to admit. I did take the time to learn a bit more about elixir and how alex koin work though. Tests would be a whole other pain and I could prob use some pairing/help on that part.

Next... we'd need to agree upon a good interaction between slack and alex koin for this. I.e. how do people chose the image they want to use.

Another caveat here is that imgflip is likely not going to store these forever. So we either have to be happy with it being short lived or figure out our own way of hosting our own images. (Maybe higher koin price for that)

So this is like 10% of the problem, but its a start. This works functionally in alex-koin-elixir-console :D

https://imgflip.com/api

@hex337
Copy link
Owner

hex337 commented Dec 25, 2020

@robotpistol I would defer to you on this PR. It seems reasonable to me, but not sure how I'd structure something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants