Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelogs #56

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Update changelogs #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
009f011
Update changelog link
schneems Dec 13, 2024
2e6833b
Add pretty assertions
schneems Dec 13, 2024
85315a1
Update jruby changelog link
schneems Dec 13, 2024
b9ea17f
Expected on the left
schneems Dec 13, 2024
f60e618
Fix tests and don't break newline
schneems Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ libherokubuildpack = { version = "0.24.0", default-features = false, features =
# File locking (FLOCK)
fs2 = "0.4"

pretty_assertions = "1.4.1"
2 changes: 1 addition & 1 deletion jruby_executable/src/bin/jruby_changelog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fn jruby_changelog(args: &Args) -> Result<(), Box<dyn Error>> {
let changelog = formatdoc! {"
## JRuby version {version} is now available
[JRuby v{version}](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
[JRuby v{version}](/articles/ruby-support-reference#ruby-versions) is now available on Heroku. To run
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:
```ruby
Expand Down
3 changes: 3 additions & 0 deletions ruby_executable/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ libherokubuildpack = { workspace = true }
chrono = { workspace = true }
sha2 = { workspace = true }
gem_version = { workspace = true }

[dev-dependencies]
pretty_assertions = { workspace = true }
9 changes: 5 additions & 4 deletions ruby_executable/src/bin/ruby_changelog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ where
let changelog = formatdoc! {"
## Ruby version {version} is now available

[Ruby v{version}](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
[Ruby v{version}](/articles/ruby-support#ruby-versions) is now available on Heroku. To run \
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:

```ruby
Expand Down Expand Up @@ -72,6 +72,7 @@ fn main() {
#[cfg(test)]
mod test {
use super::*;
use pretty_assertions::assert_eq;

#[test]
fn regular_release() {
Expand All @@ -86,7 +87,7 @@ mod test {

## Ruby version 3.3.2 is now available

[Ruby v3.3.2](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
[Ruby v3.3.2](/articles/ruby-support#ruby-versions) is now available on Heroku. To run \
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:

```ruby
Expand All @@ -95,7 +96,7 @@ mod test {

For more information on [Ruby 3.3.2, you can view the release announcement](https://www.ruby-lang.org/en/news/).
"};
assert_eq!(actual.trim(), expected.trim());
assert_eq!(expected.trim(), actual.trim());
}

#[test]
Expand All @@ -111,7 +112,7 @@ mod test {

## Ruby version 3.1.0-rc1 is now available

[Ruby v3.1.0-rc1](/articles/ruby-support#ruby-versions) is now available on Heroku. To run
[Ruby v3.1.0-rc1](/articles/ruby-support#ruby-versions) is now available on Heroku. To run \
your app using this version of Ruby, add the following `ruby` directive to your Gemfile:

```ruby
Expand Down
Loading