Refactor + Test + Support preview releases #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/refactor-and-test
branch
from
4673df7 to
cd792be
Compare
schneems
force-pushed
the
schneems/refactor-and-test
branch
2 times, most recently
from
813666f to
2998606
Compare
I've resisted really touching the compilation script because it had no tests. This was tolerable when we ran scripts locally and adjustments could be made on the fly. Now that we're automating them, I wanted to have more confidence in the script. To do that I iteratively extracted, tested, and then refactored code. In the process I got rid of most branching logic for features we don't support on GitHub actions today. If we need them in the future we have a git history. The unit tests are fast, but not terribly comprehensive. We could continue down this path of testing and refactoring if we choose, but this was a good enough stoping point for my needs. The only new behavior added is fixing these bugs that are all centered around preview/rc releases: - #28 - #29 - #30 While I'm at it I also added a linter (standard).
schneems
force-pushed
the
schneems/refactor-and-test
branch
from
2998606 to
d83778f
Compare
joshwlewis
reviewed
Sep 22, 2023
joshwlewis
reviewed
Sep 22, 2023
joshwlewis
approved these changes
Sep 22, 2023
Co-authored-by: Josh W Lewis <[email protected]>
schneems
force-pushed
the
schneems/refactor-and-test
branch
from
553acca to
3f5466b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've resisted really touching the compilation script because it had no tests. This was tolerable when we ran scripts locally and adjustments could be made on the fly. Now that we're automating them, I wanted to have more confidence in the script. To do that I iteratively extracted, tested, and then refactored code.
In the process I got rid of most branching logic for features we don't support on GitHub actions today. If we need them in the future we have a git history.
The unit tests are fast, but not terribly comprehensive. We could continue down this path of testing and refactoring if we choose, but this was a good enough stoping point for my needs.
The only new behavior added is fixing these bugs that are all centered around preview/rc releases:
While I'm at it I also added a linter (standard).