Prefer -C instead of cd when untar-ing

heroku · Jul 5, 2024 · aa7f478 · aa7f478
1 parent aa44be3
commit aa7f478
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/shared/src/lib.rs b/shared/src/lib.rs
@@ -27,13 +27,11 @@ pub fn untar_to_dir(tar_path: &TarDownloadPath, workspace: &Path) -> Result<(),
     // Shelling out due to https://github.com/alexcrichton/tar-rs/issues/369
     let mut cmd = Command::new("bash");
     cmd.arg("-c");
-    cmd.arg(
-        [
-            format!("cd {}", workspace.display()),
-            format!("tar xzf {}", tar_path.as_ref().display()),
-        ]
-        .join(" && "),
-    );
+    cmd.arg(format!(
+        "tar xzf {tar_file} -C {out_dir}",
+        tar_file = tar_path.as_ref().display(),
+        out_dir = workspace.display()
+    ));
     cmd.named_output().map_err(Error::CmdError)?;
 
     Ok(())