chore: fix moratorium check process for prereleases #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric <[email protected]>
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our release process to fix a problem with our prereleases.
Details
Since our prod release process is controlled through two Github workflows, I had previously added the moratorium check as a required job for each workflow. However, the create-cli-release workflow is also used by our prerelease process, for which we do not need to check the moratorium status. Unfortunately, requiring the moratorium check in this workflow resulted in prereleases not being published because the check was not being run.
This PR, then removes that requirement from the create-cli-release workflow, meaning that we will have to depend on the moratorium check in the start-gh-release workflow to catch a moratorium as part of the stable release process.