Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update legal message for addons:create and test #3122

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

k80bowman
Copy link
Contributor

Work item

Description

Updates the legal message for ai:models:create to match the desired message (see internal work item). When a user runs ai:models:create, they should get this message:
image

Testing

Prepare your environment for testing

  • Fetch this branch.
  • Run yarn && yarn build.
  • Set the HEROKU_INFERENCE_ADDON to the production canary add-on via export HEROKU_INFERENCE_ADDON="inference-staging"
  • Create a test app: heroku apps:create test-cli-plugin-ai

Actual testing

  • Run ./bin/run addons:create heroku-inference-staging:claude-3-5-sonnet -s test-cli-plugin-ai -t test-cli-plugin-ai to create a provisioned model.
  • Check that the legal message printed matches the message in the work item.
    • NOTE: The message has been changed slightly to add links to online resources
  • Delete the test app

@k80bowman k80bowman requested a review from a team as a code owner December 4, 2024 20:52
@k80bowman k80bowman force-pushed the k80/update-addons-create-legal branch from 2fd523b to c1966a2 Compare December 4, 2024 21:48
Copy link
Contributor

@zwhitfield3 zwhitfield3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked perfectly!

@zwhitfield3 zwhitfield3 merged commit 5fa4ae4 into main Dec 4, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the k80/update-addons-create-legal branch December 4, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants