Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move endpoint to ARG, headers to flag #3115

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Dec 2, 2024

GUS WI

Description

This changes the interface to telemetry command in the following ways to improve usability:

  1. In telemetry:add, moves HEADERS from an argument to a flag, and makes it not required
  2. In telemetry:add, moves endpoint from a flag to an argument
  3. In telemetry:add, makes transport not required and defaults to http
  4. In telemetry:update, moves HEADERS from an argument to a flag

@eablack eablack requested a review from a team as a code owner December 2, 2024 21:30
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eablack eablack merged commit 5bf9c76 into prerelease/10.0.0-alpha Dec 3, 2024
8 checks passed
@eablack eablack deleted the eb/change-telemetry-add branch December 3, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants