Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update help text and tests to reference heroku-24 #3042

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

joshwlewis
Copy link
Member

One of the last steps in the heroku-24 rollout plan is to set heroku-24 as the default stack for new apps. That change (https://github.com/heroku/api/pull/15582) will ship on October 23rd.

This PR updates a few areas of the CLI to match the new default. I don't think it's super important to ship this change exactly on October 23rd. A few days before or after is probably fine.

@joshwlewis joshwlewis changed the title chore(cli): update help text and tests to referenc heroku-24 chore(cli): update help text and tests to reference heroku-24 Oct 17, 2024
@joshwlewis joshwlewis force-pushed the jwl/heroku-24-default branch from 930ef7a to 31ff196 Compare October 17, 2024 19:47
@joshwlewis joshwlewis marked this pull request as ready for review October 17, 2024 20:17
@joshwlewis joshwlewis requested a review from a team as a code owner October 17, 2024 20:17
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbosio sbosio merged commit 3a4323e into main Oct 21, 2024
8 checks passed
@sbosio sbosio deleted the jwl/heroku-24-default branch October 21, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants