Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh CTC workflow #2802

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Refresh CTC workflow #2802

merged 9 commits into from
Oct 30, 2024

Conversation

angeldcampbell
Copy link
Contributor

@angeldcampbell angeldcampbell commented Apr 12, 2024 •
edited by mars
Loading

W-15021692 CLI: Add automated CTC check to the CLI release workflows

Picking up this work from where Angel left it last.

@angeldcampbell angeldcampbell marked this pull request as ready for review April 16, 2024 21:37
@angeldcampbell angeldcampbell requested a review from a team as a code owner April 16, 2024 21:37
sbosio
sbosio approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because the change from component_name to app_id looks correct, but take a look to my comment. I believe you missed to do the same path change on the step for retries.

.github/workflows/ctc.yml Show resolved Hide resolved
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:14 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:14 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:14 — with GitHub Actions Inactive
@mars mars had a problem deploying to ChangeManagement October 24, 2024 21:20 — with GitHub Actions Failure
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:27 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:27 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:27 — with GitHub Actions Inactive
@mars mars had a problem deploying to ChangeManagement October 24, 2024 21:27 — with GitHub Actions Failure
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:38 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:38 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 21:38 — with GitHub Actions Inactive
@mars mars temporarily deployed to ChangeManagement October 24, 2024 21:38 — with GitHub Actions Inactive
@mars mars temporarily deployed to ChangeManagement October 24, 2024 21:40 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:02 — with GitHub Actions Inactive
@mars mars temporarily deployed to ChangeManagement October 24, 2024 22:03 — with GitHub Actions Inactive
@mars mars changed the title change component_name to app_id Refresh CTC workflow Oct 24, 2024
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:12 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:12 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:12 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:15 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:15 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:43 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 24, 2024 22:43 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 25, 2024 17:52 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 25, 2024 17:52 — with GitHub Actions Inactive
@mars mars temporarily deployed to ChangeManagement October 25, 2024 17:52 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 29, 2024 18:02 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests October 29, 2024 18:02 — with GitHub Actions Inactive
@mars mars temporarily deployed to ChangeManagement October 29, 2024 18:03 — with GitHub Actions Inactive
@mars mars temporarily deployed to ChangeManagement October 29, 2024 21:00 — with GitHub Actions Inactive
@k80bowman k80bowman merged commit e4aa1c6 into main Oct 30, 2024
10 checks passed
@k80bowman k80bowman deleted the ctc-url-app-id branch October 30, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars mars mars left review comments

@k80bowman k80bowman k80bowman approved these changes

@sbosio sbosio sbosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angeldcampbell @mars @sbosio @k80bowman