Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.yml to use tag rather than sha #327

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Update manifest.yml to use tag rather than sha #327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3999027
Use github.ref_name for manifest git_ref
joshwlewis Sep 4, 2024
fc89591
Use ref_name for ctc check as well
joshwlewis Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
path: /tmp/heroku-${{ matrix.stack-version }}*
- name: Upload heroku runtime images to staging
run: |
bin/upload-runtime-images.sh ${{ matrix.stack-version }} ${{ github.sha }}
bin/upload-runtime-images.sh ${{ matrix.stack-version }} ${{ github.ref_name }}
joshwlewis marked this conversation as resolved.
Show resolved Hide resolved

publish-images:
if: github.ref_name == 'main' || github.ref_type == 'tag'
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
-H "ACCEPT: application/json" \
-H "Content-Type: application/json" \
-H "Authorization: Token ${{ secrets.TPS_TOKEN }}" \
-d '{"lock": {"sha": "${{ github.sha }}", "component_name": "${{ vars.tps_component }}"}}' \
-d '{"lock": {"sha": "${{ github.ref_name }}", "component_name": "${{ vars.tps_component }}"}}' \
"${{ secrets.TPS_CTC_API_URL }}"

promote-tags:
Expand Down