Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additionally publish images to public.ecr.aws #319

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Aug 9, 2024

This PR changes the publish automation to additionally push base images to public.ecr.aws/heroku/heroku. This aims to alleviate some Docker Hub rate limit concerns and enables faster downloads in some cloud environments. The primary and canonical location for these images is still heroku/heroku (on dockerhub).

This automation makes use of GitHub OIDC to authenticate with AWS so no IAM users or access tokens are in use.

We've already made similar changes for heroku/builder: heroku/cnb-builder-images#557.

GUS

@joshwlewis joshwlewis marked this pull request as ready for review August 9, 2024 19:20
@joshwlewis joshwlewis requested a review from a team as a code owner August 9, 2024 19:20
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image repo names/tags being identical make this so much nicer to implement :-)

@joshwlewis joshwlewis merged commit 2598b90 into main Aug 12, 2024
27 checks passed
@joshwlewis joshwlewis deleted the jwl/publish-ecr branch August 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants