Add c-ares to the run image for all stacks
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that PgBouncer can use its recommended `c-ares` based DNS backend: heroku/heroku-buildpack-pgbouncer#188 https://www.pgbouncer.org/install.html The package is named `libcares2` on Heroku-24 and `libc-ares2` on older stacks: https://packages.ubuntu.com/noble/libcares2 https://packages.ubuntu.com/jammy/libc-ares2 https://packages.ubuntu.com/focal/libc-ares2 This only adds ~200 KB to the run image. I've not added the corresponding headers to the build image, since: - For the PgBouncer use-case they can instead be installed in the build environment used to compile the PgBouncer binaries. - There don't seem to be any popular `c-ares` language bindings that people might use directly in their apps.
Malax
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that PgBouncer can use its recommended
c-aresbased DNS backend:heroku/heroku-buildpack-pgbouncer#188
https://www.pgbouncer.org/install.html
https://c-ares.org/
The package is named
libcares2on Heroku-24 andlibc-ares2on older stacks:https://packages.ubuntu.com/noble/libcares2
https://packages.ubuntu.com/jammy/libc-ares2
https://packages.ubuntu.com/focal/libc-ares2
This only adds ~200 KB to the run image.
I've not added the corresponding headers to the build image, since:
c-areslanguage bindings that people might use directly in their apps.GUS-W-15826387.