Heroku-24: Re-sync ARM64 package lists #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regenerates the ARM64 packages list to match reality after #292. CI unfortunately didn't catch this, since it currently only validates the AMD64 list due to (a) the limitations around Docker on Linux not supporting the containerd snapshotter and so multi-arch images, and (b) the fact CI currently builds both architectures on the same machine. Also, the reason my running the build generation script locally didn't update the ARM64 manifests, is that when I'm image size benchmarking I sadly have to disable the containerd snapshotter since it has broken image size calculations. With the current build scripts for this repo, that results in only AMD64 being generated locally. GUS-W-15616760.
joshwlewis
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regenerates the ARM64 packages list to match reality (and the AMD64 lists) after #292.
CI unfortunately didn't catch this, since it currently only validates the AMD64 list due to (a) the limitations around Docker on Linux not supporting the containerd snapshotter and so multi-arch images in the local store, and (b) the fact CI currently builds both architectures on the same machine.
Also, the reason my running the build generation script locally didn't update the ARM64 manifests, is that when I'm image size benchmarking I sadly have to disable the containerd snapshotter since it has broken image size calculations (and I have to remember to toggle it on and off repeatedly depending on what I'm doing). With the current build scripts for this repo, that results in only AMD64 being generated locally.
GUS-W-15616760.