Skip running the "unpublish temp tags" step in CI for PRs #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the "unpublish temp tags" GitHub Actions step is always run, even if no tags were generated that run (such as for PRs, where we don't publish anything). Whilst this doesn't cause any harm normally, when contributors open a PR from a fork, the "unpublish temp tags" will fail since it doesn't have access to the secrets required to perform the (redundant) unpublish. As such, the step now uses the same `if` ref-related conditionals that the publish step itself uses (so we only try to unpublish if this was a job type that publishes something). This fixes the failures seen in #269: https://github.com/heroku/base-images/actions/runs/8351455845/job/22859813877?pr=269
runesoerensen
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "unpublish temp tags" GitHub Actions step is always run, even if no tags were generated that run (such as for PRs, where we don't publish anything).
Whilst this doesn't cause any harm normally, when contributors open a PR from a fork, the "unpublish temp tags" will fail since it doesn't have access to the secrets required to perform the (redundant) unpublish.
As such, the step now uses the same
ifref-related conditionals that the publish step itself uses (so we only try to unpublish if this was a job type that publishes something).This fixes the failures seen in #269:
https://github.com/heroku/base-images/actions/runs/8351455845/job/22859813877?pr=269
GUS-W-15292389.