Remove CNB_TARGET_* env vars workaround
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added recently in #251 to work around this upstream `lifecycle` bug: buildpacks/lifecycle#1308 The fix for that has since been released in lifecycle 0.19.0: https://github.com/buildpacks/lifecycle/releases/tag/v0.19.0 Which our builder images are now using: heroku/cnb-builder-images#475 As such, we no longer need the workaround here (and in fact, setting these env vars now cannot have an effect, since `lifecycle` now ignores them).
Malax
approved these changes
Mar 11, 2024
|
I might need to revisit this, pending: I also noticed a way to improve test coverage, for which I opened: |
edmorley
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 15, 2024
To pick up this backported fix: buildpacks/lifecycle#1317 ...so that these images still work after the removal of the `CNB_TARGET_*` env vars workaround in: heroku/base-images#260 Release notes: https://github.com/buildpacks/lifecycle/releases/tag/v0.17.5 Full changelog: buildpacks/lifecycle@v0.17.4...v0.17.5 GUS-W-15225541.
And backported to v0.17.5: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added recently in #251 to work around this upstream
lifecyclebug:buildpacks/lifecycle#1308
The fix for that has since been released in lifecycle 0.19.0:
https://github.com/buildpacks/lifecycle/releases/tag/v0.19.0
Which our builder images are now using:
heroku/cnb-builder-images#475
As such, we no longer need the workaround here (and in fact, setting these env vars now cannot have an effect, since
lifecyclenow ignores them).GUS-W-15225541.