Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to docker push image manifests #253

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Mar 4, 2024

CI is failing here, with the following error:

+ docker push heroku/heroku:24.nightly
The push refers to repository [docker.io/heroku/heroku]
tag does not exist: heroku/heroku:24.nightly

That's because we're attempting to docker push a multi-arch image manifest. docker push supports images, not manifests. The equivalent command for a manifest list is docker manifest push, but we actually don't need that - the docker buildx manifest create command already publishes the image (as you can see here).

@joshwlewis joshwlewis requested a review from a team as a code owner March 4, 2024 19:19
@joshwlewis joshwlewis enabled auto-merge (squash) March 4, 2024 19:20
@joshwlewis joshwlewis merged commit dc7eac7 into main Mar 4, 2024
4 checks passed
@joshwlewis joshwlewis deleted the adjust-multiarch-push branch March 4, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants